From b733b2334c26fe7d6a637aa6e90f55b2eb0a8bd5 Mon Sep 17 00:00:00 2001 From: Randy Bush Date: Sat, 6 Feb 2021 16:26:24 -0800 Subject: [PATCH] alexander review --- draft-ietf-sidrops-8210bis.xml | 71 +++++++++++++++++++--------------- 1 file changed, 40 insertions(+), 31 deletions(-) diff --git a/draft-ietf-sidrops-8210bis.xml b/draft-ietf-sidrops-8210bis.xml index 09c97e2..c8ab003 100644 --- a/draft-ietf-sidrops-8210bis.xml +++ b/draft-ietf-sidrops-8210bis.xml @@ -10,7 +10,7 @@ - + @@ -75,7 +75,7 @@ platforms. - This document updates . + This document updates . describes the deployment structure, and @@ -110,14 +110,14 @@
This section summarizes the significant changes between - and the protocol described in this + and the protocol described in this document. - New ASPA PDU type () added to support - . + A new ASPA PDU type () has added to + support . A small section, , has been added to @@ -125,8 +125,9 @@ Shorter Prefix First. - Protocol version number incremented from 1 (one) to 2 - (two). + The protocol version number incremented from 1 (one) to 2 + (two) and the section has been + updated accordingly. @@ -526,7 +527,7 @@ The rationale for this approach is that the entire purpose of the RPKI&nbhy;Router protocol is to offload work from the router - to the cache, and it should therefore be the cache's job to + to the cache, and it should therefor be the cache's job to simplify the change set, thus reducing work for the router. @@ -974,10 +975,15 @@ same Customer Autonomous System Number and the same Address Family (see Flags field), replaces the previous one. This is to avoid a race condition when a BGP announcement is received - between an withdrawn PDU and a new announced PDU. Therfore, the - cache SHOULD deliver entire data of an ASPA record in a single + between an withdrawn PDU and a new announced PDU. Therefor, the + cache MUST deliver entire data of an ASPA record in a single ASPA PDU. + The router should only see one ASPA for a particular Customer + Autonomous System Number active at any time. This may place a + burden on the cache to merge multiple ASPA records it has + received from the global RPKI into one ASPA PDU. + The Flags field is defined as follows:
@@ -1090,39 +1096,41 @@ which version of this protocol the router implements. - If a cache which supports version 1 receives a query from a - router which specifies version 0, the cache MUST downgrade to - protocol version 0 or send a version - 1 Error Report PDU with Error Code 4 ("Unsupported Protocol - Version") and terminate the connection. + If a cache which supports version N receives a query from a + router which specifies version Q < N, the cache MUST downgrade + to protocol version Q or or send a version 1 Error Report PDU with + Error Code 4 ("Unsupported Protocol Version") and terminate the + connection. - If a router which supports version 1 sends a query to a cache - which only supports version 0, one of two things will happen: + If a router which supports version N sends a query to a cache + which only supports version C < N, one of two things will + happen: The cache may terminate the connection, perhaps with a version 0 Error Report PDU. In this case, the router MAY - retry the connection using protocol version 0. + retry the connection using protocol version C. - The cache may reply with a version 0 response. In this - case, the router MUST either downgrade to version 0 or + The cache may reply with a version C response. In this + case, the router MUST either downgrade to version C or terminate the connection. - In any of the downgraded combinations above, the new features - of version 1 will not be available, and all PDUs will have 0 - in their version fields. + In any of the downgraded combinations above, the new features of + the hogher version will not be available, and all PDUs will have + the negotiated lower version number in their version fields. If either party receives a PDU containing an unrecognized - Protocol Version (neither 0 nor 1) during this negotiation, it - MUST either downgrade to a known version or terminate the - connection, with an Error Report PDU unless the received PDU - is itself an Error Report PDU. + Protocol Version (neither 0, 1, nor 2) during this negotiation, + it MUST either downgrade to a known version or terminate the + connection, with an Error Report PDU unless the received PDU is + itself an Error Report PDU. The router MUST ignore any Serial Notify PDUs it might receive @@ -1140,9 +1148,9 @@ Caches SHOULD NOT send Serial Notify PDUs before version - negotiation completes. Routers, however, MUST handle - such notifications (by ignoring them) for backwards - compatibility with caches serving protocol version 0. + negotiation completes. Routers, however, MUST handle such + notifications (by ignoring them) for backwards compatibility + with caches serving protocol version 0. Once the cache and router have agreed upon a Protocol Version @@ -1829,7 +1837,7 @@ Cache Router This section only discusses updates required in the existing IANA protocol registries to accommodate version 1 of this - protocol. See for IANA considerations + protocol. See for IANA considerations from the original (version 0) protocol. @@ -1907,6 +1915,7 @@ Cache Router +